search

accumulator / Quickddit

Reddit client for Jolla's SailfishOS, Ubuntu Touch and Nokia N9
GNU General Public License v3.0
53 stars 21 forks source link

Use openInTextLink() to open the post URL from the CommentPage #2

Closed g7 closed 9 years ago

g7 commented 9 years ago

This makes Quickddit open an in-reddit URL (for example, the ones in /r/bestof) inside the application.

Seems to work fine in my Jolla, even if I don't know if this is the right way to accomplish this. :)

I haven't tested the Harmattan change as I don't have an N9.

Eugenio

accumulator commented 9 years ago

Yes, this is how it could be done, thanks.

However, I want the button with the globe symbol to always be handled as an 'open outside of the app' share-like action, so I think the preview button is a better place for this (some sort of reddit icon would be nice to have for that). Also, right now it can only open links to reddit comments, not to subreddits yet.

This feature is high on the list though, so stay tuned.

g7 commented 9 years ago

Uh, that's great to know! I'll wait patiently then :)

Eugenio

accumulator commented 9 years ago

due to lack of a reddit button icon (for now) I've implemented it on the globe button.