Load Flickable for comments only if necessary.

accumulator / Quickddit

Reddit client for Jolla's SailfishOS, Ubuntu Touch and Nokia N9

GNU General Public License v3.0

53 stars 21 forks source link

Load Flickable for comments only if necessary. #6

Closed nodevel closed 9 years ago

nodevel commented 9 years ago

This pull request should make Quickddit better optimized. The last change towards the ability to load wide comments introduced Flickable to each and every comment (hundreds of occurrences), often triggering the 'Application not responding' warning. This fix will load Flickable only if the comment is actually wide (very low percentage of comments), not every time. Additionally, it will also fix the ListItem highlight broken in the last release.

nodevel commented 9 years ago

This is weird - I was quite sure I made the pull request against your repo (accumulator/Quickddit), but it looks like the file has been compared to the initial version by dicksonleong. So if the merging doesn't work, please just manually copy the changes and compare it to your version.

accumulator commented 9 years ago

you can rebase your branch on master and re-push with -f (force) flag