accumulator / Quickddit

Reddit client for Jolla's SailfishOS, Ubuntu Touch and Nokia N9
GNU General Public License v3.0
53 stars 21 forks source link

Inintial ubuntu touch support #65

Closed dano6 closed 4 years ago

dano6 commented 4 years ago

This PR brings initial support for Ubuntu Touch. Some minor changes was done for backend, please check if Sailfish builds fine. Minimal version of QT is 5.9, using Qt Quick Controls 2. Ubuntu specific API was not yet used (notifications, sharing, uploading and downloading files), as I am not sure yet how to separate it from other code. I want to keep code buildable for any Linux distro. I am committing myself to maintain code in ubuntu-touch folder, any help is welcomed. I would love to publish app latter in OpenStore, if you are OK with that.

Features not implemented yet:

Build instructions for PC:

Build instructions for Ubuntu Touch:

dano6 commented 4 years ago

@accumulator can you please give me some contact? I would love to ask couple questions.

accumulator commented 4 years ago

Hi @dano6 You can email me at quickddit[at]outrightsolutions.nl for any questions you have!

Some minor changes was done for backend, please check if Sailfish builds fine.

From a quick glance it looks like the backend changes will compile fine. I can test later this week.

Ubuntu specific API was not yet used (notifications, sharing, uploading and downloading files), as I am not sure yet how to separate it from other code. I want to keep code buildable for any Linux distro.

There is some platform specific code in qmlutils.cpp in the backend code tree, which is mostly Qt4 vs Qt5 #ifdefs and some UI scaling trickery that makes various sailfish device ports look similar, but there's also platform specific stuff that should really be moved out of the backend tree at some point :)

For now, if you can #ifdef it into qmlutils.cpp that's fine, or if you want to add code in /ubuntu-touch/src and make it available to QML scope that's also fine, but keep in mind that there should be no direct dependency on platform specific code from the backend code.

I would love to publish app latter in OpenStore, if you are OK with that

Please do! :)

accumulator commented 4 years ago

Also,

accumulator commented 4 years ago

I tried it out, it looks very good. Also quite some functionality already. Very different style, but I could find my way around.

Love the hot search bar for subreddits!

dano6 commented 4 years ago

Thanks for all hints and the merge! Also, I wanted to say that the backend is well written and easy to work with.

I tried it out, it looks very good. Also quite some functionality already. Very different style, but I could find my way around. Love the hot search bar for subreddits!

I am glad you like it.