accumulator / Quickddit

Reddit client for Jolla's SailfishOS, Ubuntu Touch and Nokia N9
GNU General Public License v3.0
53 stars 21 forks source link

Sailfish: Switch out SilicaWebview for SailfishWebview #87

Closed Thaodan closed 1 year ago

Thaodan commented 2 years ago

This change replaces the WebKit based Webview witha Gecko based Webview. Busyindicator is not needed since SailishWebview provides its own.

WIP because:

Thaodan commented 1 year ago

Only the last commit is part of this PR, the rest is part of #86.

Thaodan commented 1 year ago

Status update:

WebViewPage

SignInPage

What works:

What doesn't:

Thaodan commented 1 year ago

@accumulator: What kind of redirect url are you using?

Thaodan commented 1 year ago

Status Update

The page has been rewritten with a Sailfish WebView element instead of a SilicaWebview.

To adjust the page, improve the layout and work better with the Sailfish WebView I replaced the AbstractPage with Dialog. The page was more of a dialog in any case, the reload option was redundant.

While doing so I replaced the copyright text with SPDX tags.

Context regarding the copyright text changes: