replace youtube-dl with yt-dlp

accumulator / Quickddit

Reddit client for Jolla's SailfishOS, Ubuntu Touch and Nokia N9

GNU General Public License v3.0

53 stars 21 forks source link

replace youtube-dl with yt-dlp #90

Closed caio2k closed 2 years ago

caio2k commented 2 years ago

hello @accumulator! thanks for all your work done in quickddit due to youtube-dl going eol I've tried to update it to more modern ytdl-dlp. Main improvement is being able to watch again youtube videos in the embedded player, now they do not take 2 min just to load. I've tested this change in sailfish arm64 but I cannot ensure sailfish arm nor ubuntu will work.

accumulator commented 2 years ago

Great work @caio2k, looks good!

It'll probably work fine on other archs and platforms, unless they pulled in weird new dependencies, but I doubt that.

I'll check in a few weeks, as I'm quite busy a.t.m. and my sailfish SDK got hosed again due to my CGroupsV2 setup which the SDK upgrade/installer doesn't like or can recover from (sigh)

accumulator commented 2 years ago

In the meantime maybe @dano6 can check for ubuntu ?

dano6 commented 2 years ago

It would work, but in xenial we have only Python3.5, so I will ship this after focal update