accumulator / plugin.video.lbry

This is a basic plugin for accessing LBRY content in Kodi/XBMC
GNU General Public License v2.0
26 stars 6 forks source link

Queueing/playing via the Kodi Android app doesn't work #2

Open mrzapp opened 3 years ago

mrzapp commented 3 years ago

Thanks for this add-on, very useful!

When using the LBRY app on a phone, one should be able to press "Share" and pick "Play on Kodi", this works with YouTube/Vimeo/etc.

This is just me guessing, but I suppose the app sends the raw LBRY URL to Kodi, which then asks all installed add-ons whether they can handle the destination/protocol, and currently fails because this add-on doesn't implement this interface.

If you'd like help on this, I can research a bit more and send a pull request?

buffoon86 commented 3 years ago

From what I can see the plugin is missing a URL Handler to make kodi understand that URLs in the form of https://lbry.tv/@lbry:3f/odysee:7 (that's the form I get when sharing by mail) should be opened with the plugin.

accumulator commented 3 years ago

@mrzapp Sure, PRs welcome!

mrzapp commented 3 years ago

@buffoon86 do you have any idea how to achieve it? I've started a thread on the support forum for now, as I can't seem to dig up anything about it.

buffoon86 commented 3 years ago

@mrzapp I'm sorry but no. I tried to study some documentation too but didn't get idea on how kodi does this. I hope the forum will help.

accumulator commented 3 years ago

There's an uri2addon script as described here : https://forum.kodi.tv/showthread.php?tid=228877

It's an older post, so not sure how it's done in recent Kodi, but at least the youtube plugin code still seems to refer to uri2addon by providing a plugin:/uri2addon/.* path binding. There's no explicit dependency on such a script in the youtube plugin, but maybe it has become convention in kodi. Can't find any documentation though..

mrzapp commented 3 years ago

@accumulator ah, bollocks. As far as I can tell from the last post in that thread, it's up to the remote control app to hardcode support for different plugins. That's just really broken. But I suppose I'll just open an issue on the Kore repo, then.

UPDATE:

The issue is here