accumulator / plugin.video.lbry

This is a basic plugin for accessing LBRY content in Kodi/XBMC
GNU General Public License v2.0
26 stars 6 forks source link

Odysee Integration #29

Open azzy9 opened 1 year ago

azzy9 commented 1 year ago

Hi @accumulator, I really enjoy your plugin, but to fit my needs I created a fork with Odysee Integration: https://github.com/azzy9/plugin.video.lbryplus I made my own fork since I do not know what path you wish to take your plugin, but you can use any of my code if you want to include the functionality. Or if you wish for me to make a PR just let me know.

accumulator commented 1 year ago

Hi azzy9, thanks for getting in touch.

From a quick cursory look (am a bit busy this month) at your code it seems you're pretty far along already :)

I'm certainly interested merging this, but it'll take a few weeks before I can take a deeper look. I think the main challenge is combining Odysee specific parts with LBRY specific parts without confusing the user..

azzy9 commented 1 year ago

Hi @accumulator, thanks for getting back.

I am glad you wish to include the functionality, I made it as a separate plugin for my own use in case you didn't wish to have it merged.

I made a checkbox in settings to enable the Odysee integration to try and keep it separated. This then loads the external class instead of the local class. Or do you wish to have both LBRY & Odysee functionality running at the same time.

There is one thing I need to do and that is better handling of checking if the user is logged in using the /user/me endpoint. It is currently just a stored setting and doesn't actually check if the user is logged in.

DanTheOracle commented 1 year ago

i have tried loads of apps and would love to try this one and help you develop it. sadly i dont have the time to compile or work out how to even install it without some instructions.

azzy9 commented 1 year ago

Hi @DanTheOracle,

Both this project (lbry) & my fork (lbry+) are plugins for Kodi. You will need to have kodi intsalled.

You will then need to download and then install the zip. From my fork it is in the releases.

To install: https://kodi.wiki/view/Archive:Install_add-ons_from_zip_files