search

accupara / crave

Release vehicle for the crave command line tool
Other
7 stars 5 forks source link

Should 'os' be upper case? #6

Closed adityaathalye closed 1 year ago

adityaathalye commented 1 year ago

The global variable is OS, and a check for unknown references this. However in-between, a variable os is being set to the OS type.

e.g. https://github.com/accupara/crave/blob/22312cad9e21f095a86dd4b732bf10f3c0d45dfa/get_crave.sh#L12

adityaathalye commented 1 year ago

Also, here, variable expansion is missing. It should be "$OS":

https://github.com/accupara/crave/blob/22312cad9e21f095a86dd4b732bf10f3c0d45dfa/get_crave.sh#L21

uvatbc commented 1 year ago

You're absolutely right; good catch. Fixing in a moment.

uvatbc commented 1 year ago

Fixed at https://github.com/accupara/crave/commit/85cc0cc4e674893e3ccab40cad8a948c231b4183