accurat / accurapp

Create JS apps with flexible build configuration, tailored for the specific needs of Accurat
MIT License
21 stars 5 forks source link

README outdated: suggested SASS configuration doesn't work #50

Closed NoFishLikeIan closed 5 years ago

NoFishLikeIan commented 5 years ago

The configuration described here gives now an error:

https://github.com/accurat/accurapp#customizing-webpack

const { buildWebpackConfig } = require('webpack-preset-accurapp')
const { sass } = require('webpack-blocks')

module.exports = buildWebpackConfig([
  sass(),
])
marcofugaro commented 5 years ago

const { sass } = require('webpack-blocks')

becomes

const { sass } = require('@webpack-blocks/sass')

can you make a PR?

ivanross commented 5 years ago
const { buildWebpackConfig } = require('webpack-preset-accurapp')
const { match } = require('@webpack-blocks/webpack')
const { css } = require('@webpack-blocks/assets')
const sass = require('@webpack-blocks/sass')

module.exports = buildWebpackConfig([
  match(['*.scss'], [css(cssOptions), postcss(postcssOptions), sass()]),
])
NoFishLikeIan commented 5 years ago

@ivanross I'll assign you to it.

marcofugaro commented 5 years ago

@ivanross yes, also the cssOptions and postcssOptions should be made exportable like this

const { buildWebpackConfig, cssOptions, postcssOptions } = require('webpack-preset-accurapp')