search

accurat / accurapp

Create JS apps with flexible build configuration, tailored for the specific needs of Accurat
MIT License
21 stars 5 forks source link

Generator star spacing rule #51

Closed NoFishLikeIan closed 5 years ago

NoFishLikeIan commented 5 years ago

We currently have a conflict between the rules in eslint and the formatting in prettier. In particular eslint forces to put a space before the generator function * fetchOutsample() and prettier defaults to function* fetchOutsample(). I like the prettier version more and would remove the eslint rule but I wanted to raise the issue to @marcofugaro first. For now you can do:

// .eslintrc
{
  "extends": "eslint-config-accurapp",
  "rules": {
    "generator-star-spacing": 0
  }
}
marcofugaro commented 5 years ago

function* fetchOutsample() is correct. This is also a conflict between prettier and eslint-config-standard, we should put this in the accurapp configuration, it resets it to the default:

'generator-star-spacing': 'warn',