search

acdamiani / schema

Visual intelligence for the Unity game engine
https://schema-ai.com
MIT License
53 stars 4 forks source link

Conditional is evaluated even if corresponding node is not running #18

Open ijisthee opened 8 months ago

ijisthee commented 8 months ago

Hi @acdamiani

how to reproduce? image

In this example I would expect that only two checks are made since the tree should never reach this node: image

But unfortunately all three conditionals are checked. Only when a conditional has abort conditions.

If this is intended I would like to understand the advantage.

Best, Christian

acdamiani commented 8 months ago

Yep, this is an oversight. Try a git checkout on this commit: eccf515abd6a0b430046cfbbe9cf9e284935fe5d. Let me know if your issue is fixed; I want to do some more testing before merging the associated pull request.

ijisthee commented 8 months ago

Edit2: The issue described below does not occur in https://github.com/acdamiani/schema/commit/d534e51aebe662622a6a8b713ed31f8c644fd510 but only in https://github.com/acdamiani/schema/commit/542a80e1c95a74c6d0f771974e559ea5d5bb5aef and https://github.com/acdamiani/schema/commit/eccf515abd6a0b430046cfbbe9cf9e284935fe5d

Cannot really test it, since this issue is back again: https://github.com/acdamiani/schema/issues/5

image

Edit: No, it's something else. A Debug.Log(hit.entryType); in Runtime/Nodes/Physics/OverlapSphere.cs shows Null. The Entry is set: image

And also available in BlackBoard: image

acdamiani commented 8 months ago

I just pushed a fix for the resurgence of #5. I'll do some more testing for #19 to make sure this issue is fixed before merging it.