acdh-oeaw / apis-core

https://acdh-oeaw.github.io/apis-core/
MIT License
11 stars 3 forks source link

EMERGENCY: merge doesn't work #341

Closed sviatoplok closed 2 years ago

sviatoplok commented 2 years ago

When merging an entity into another, server error 500 occurs. Maybe the same problem as in #304

sennierer commented 2 years ago

can you please post the url of the entity you were working on and the search term for the one you tried to merge?

sviatoplok commented 2 years ago

occurded eg when merging

Serbia

into

Serbien

sviatoplok commented 2 years ago

or

Italy

into

Italien

gregorpirgie commented 2 years ago

Appears to be a self merge, not an issue. Please check if you didn't accidentally try to merge an entity on/with itself. If otherwise and still an active issue – I am watching this issue here, so please simply post an update and I will look into it @sviatoplok.

gregorpirgie commented 2 years ago

Also if not an issue, please report back and I will close it here.

sviatoplok commented 2 years ago

OK, same geonames URI, same geo coordinates, insofar it is a self merge. The goal of merging was to get the URI of the one entry into the other, similar to problem described in #304 I will try as suggested there.

sennierer commented 2 years ago

as gregor mentioned this was to the system a self merge, because - at least in the serbia case - both entities had the same geonames uri. The only difference is that one uri uses https, the other http. Probably the http uri was introduced before we came up with the uri harmonization script. Problem is the harmonization we are now using. The system harmonizes the http geonames uri to https and retrieves the wrong object from the db. This is related to #337 , as soon as this is resolved the error should be gone.

sviatoplok commented 2 years ago

OK, same geonames URI, same geo coordinates, insofar it is a self merge. The goal of merging was to get the URI of the one entry into the other, similar to problem described in #304 I will try as suggested there.

Could't get the URI of the db entry to be deleted into the db entry I want to keep, because it already exists. Will wait until merge works.

sennierer commented 2 years ago

as mentioned here:

as gregor mentioned this was to the system a self merge, because - at least in the serbia case - both entities had the same geonames uri. The only difference is that one uri uses https, the other http. Probably the http uri was introduced before we came up with the uri harmonization script. Problem is the harmonization we are now using. The system harmonizes the http geonames uri to https and retrieves the wrong object from the db. This is related to #337 , as soon as this is resolved the error should be gone.

this issue should be resolved as #337 is fixed in latest

sennierer commented 2 years ago

please reopen if thats not the case

skurzinz commented 2 years ago

I tested it now by merging Serbia into Serbien as suggested by @sviatoplok above, and it seems to have worked.