search

acdh-oeaw / apis-instance-frischmuth

1 stars 1 forks source link

conflicting info for `ExpressionData` in `/api/work-preview` response vs. openapi doc #132

Closed stefanprobst closed 4 months ago

stefanprobst commented 4 months ago

for the /api/work-preview/ response shape, the openapi doc says results[].expression_data[].edition_type and results[].expression_data[].language have type string, however the actual api endpoint returns an array.

see ExpressionData schema

see response:

curl https://frischmuth-dev.acdh-dev.oeaw.ac.at/api/work-preview/ | jq '.results[].expression_data[].edition_type'
curl https://frischmuth-dev.acdh-dev.oeaw.ac.at/api/work-preview/ | jq '.results[].expression_data[].language'
koeaw commented 4 months ago

@stefanprobst This is indeed a known issue, see this comment from end of May.

stefanprobst commented 4 months ago

the issue you linked to is already closed - does that mean this should be fixed with the next backend deployment?

koeaw commented 4 months ago

the issue you linked to is already closed - does that mean this should be fixed with the next backend deployment?

No, it means the issue is done (the core issue, the issue at hand was solved) and needs to be followed up with a new issue. Which lives here.

Same for issues labelled "DONE", incidentally, which I only keep open because I need to be able to differentiate "recently closed" issues from the rest of them on the board.

stefanprobst commented 4 months ago

i just want to know which issue to subscribe to to get notified when this is solved. i guess that's https://gitlab.oeaw.ac.at/acdh-ch/frischmuth/backend/apis-instance-frischmuth/-/issues/157.