search

acdh-oeaw / apis-oebl-research-tool-front-end

See also https://redmine.acdh.oeaw.ac.at/issues/18296
https://oebl-research.acdh-dev.oeaw.ac.at
MIT License
0 stars 0 forks source link

attach existing gender field to backend #19

Closed sennierer closed 2 years ago

sennierer commented 2 years ago

gender field is available in frontend, but changes are not synced to the backend yet. fields are not available in master backend yet. in relation to oebl-irs-devops#31

sennierer commented 2 years ago

changed due date to February 25, 2022

sennierer commented 2 years ago

marked this issue as related to oebl-irs-devops#31

sennierer commented 2 years ago

as a side note: the choices for the gender field should be fetched from the enum definition in the OpenAPI spec of the backend

sennierer commented 2 years ago

marked this issue as related to #22

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Feb 15, 2022, 09:07

created branch 19-attach-existing-gender-field-to-backend to address this issue

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Feb 15, 2022, 12:37

mentioned in commit 73971134304aed7e8832417e9f460950ed8e9a98

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Feb 15, 2022, 12:39

@sennierer

Regarding https://gitlab.com/acdh-oeaw/oebl/oebl-research-tool-front-end/-/commit/73971134304aed7e8832417e9f460950ed8e9a98

From the commit message:

https://gitlab.com/acdh-oeaw/oebl/oebl-research-tool-front-end/-/issues/19#note_824511120

I guess this refers to (CHOICES_GENDER in the backend)[https://gitlab.com/acdh-oeaw/oebl/oebl-irs-devops/-/blob/dev-new-entities/oebl_research_backend/models.py#L9], which I do not find exposed in the OpenAPI spec.

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Feb 16, 2022, 11:16

@sennierer

Just came across this pre-existing issue:

  1. Gender is editable in the table, but is not a drop down.
  2. If auto-filled (by LemmaDetail) it shows the abbreviation of the gender (f instead of female)
  3. If a "wrong" value is filled in ("männlich") and you click on the table row, it auto-fills the value as in 2, which makes a weird user experience.
sennierer commented 2 years ago

mentioned in commit oebl-irs-devops@598268cddec8728a7bf0370571ead17aa320c09a

sennierer commented 2 years ago

mentioned in commit oebl-irs-devops@03447a0c57a4aece2c2026516a45a1fb8aafd7bd

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Feb 21, 2022, 09:32

mentioned in commit c794755acbd7fd5d876601a955a26b7b38647b0b

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Feb 21, 2022, 10:06

mentioned in commit a2a231ef00e4120ab9fadd7a2583cbda7ab73536

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Feb 21, 2022, 10:06

mentioned in commit 788a8af165280e10aac0571a2813c3d0ff5a5444

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Feb 21, 2022, 10:07

created branch 19-attach-existing-gender-field-to-backend-2 to address this issue

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Feb 21, 2022, 12:43

mentioned in commit bee0a33f437399988158cd01222f73d4d4298a98

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Mar 9, 2022, 13:52

mentioned in commit 9c7a26f38f0e2c5aff97ca2180c97c6172524b38