Remodel alternativeNames

acdh-oeaw / apis-oebl-research-tool-front-end

See also https://redmine.acdh.oeaw.ac.at/issues/18296

https://oebl-research.acdh-dev.oeaw.ac.at

MIT License

0 stars 0 forks source link

Remodel alternativeNames #20

Closed sennierer closed 2 years ago

sennierer commented 2 years ago

New Issue

Define alternative names as given name - family name pairs.

UX

Remove + buttons on Vorname and Nachname
Add + buttton for alternative names below.
- On click: new Vorname, Nachname field group

Data model

New

alternativeNames: [{firstName: string?, lastName: string?,}, ]

Old for reference

alternativeLastNames?: string[],
alternativeFirstNames?: string[],

Original Issue

we need an array of alternative first names and sync that array to the backend. the field in the backend is not yet in master. in relation to oebl-irs-devops#29

Notes

This now includes also the last name issues, which I will close then.

sennierer commented 2 years ago

changed due date to March 04, 2022

sennierer commented 2 years ago

marked this issue as related to oebl-irs-devops#29

sennierer commented 2 years ago

marked this issue as related to #21

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Feb 16, 2022, 11:24

@sennierer

This is not in https://gitlab.com/acdh-oeaw/oebl/oebl-research-tool-front-end/-/tree/dev-new-entities, or?
I can not fantasize, where this would belong to. Now there is a free-text field "Vorname", combined with <text-field-alternatives>, which allows to add more given names.

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Feb 18, 2022, 12:44

created branch 20-add-new-field-first_name_alternative-array-and-attach-to-backend to address this issue

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Feb 21, 2022, 09:02

Removed

Display alternative names in VirtualTable (currently each given and family name is displayed as json)

from this issue – this should be a new issue, which I will create, when this one is done and the visual representation of the new data structure is apparent.

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Feb 22, 2022, 11:53

mentioned in commit 9593de19f91971413af75e6cf00dff2c685af267

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Feb 22, 2022, 11:53

mentioned in commit 31cceb4e659549905c4cac59d2f694f940fbb2f0

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Feb 23, 2022, 14:58

mentioned in commit 8d7735bbd78c255ddc8bec4e8422e9d288782bff

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Feb 23, 2022, 14:59

Last commit resolves this issue