acdh-oeaw / apis-oebl-research-tool-front-end

See also https://redmine.acdh.oeaw.ac.at/issues/18296
https://oebl-research.acdh-dev.oeaw.ac.at
MIT License
0 stars 0 forks source link

frontend does not accept an empty alternativeNames array #35

Closed sennierer closed 2 years ago

sennierer commented 2 years ago

Detail view is not rendered when the response from the server does not contain any alternative names error log attached

undefined

sennierer commented 2 years ago

changed due date to March 11, 2022

sennierer commented 2 years ago

other than stated before this seems to be not related to alternative names being returned....tested it with an array of alternative names and got the same error.

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Mar 7, 2022, 16:53

created branch 35-frontend-does-not-accept-an-empty-alternativenames-array to address this issue

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Mar 7, 2022, 17:04

mentioned in commit b9b90725ff3bb857b1f585305572ad83deccd5ce

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Mar 7, 2022, 17:36

mentioned in commit 5c7cfc32f32efb5228a0a417f76a2d92d4356797

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Mar 7, 2022, 17:44

@sennierer I have not been able to reproduce this, which might be caused by different somewhere in user_columns, but I believe this commit might have repaired it? I will now merge it into dev-backup anyway, since it causes bugs.

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Mar 10, 2022, 09:28

created branch 35-frontend-does-not-accept-an-empty-alternativenames-array-2 to address this issue

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Mar 11, 2022, 14:14

mentioned in commit c08f18dcb7a6c232e894b57813e0b71d18d39c21