search

acdh-oeaw / apis-oebl-research-tool-front-end

See also https://redmine.acdh.oeaw.ac.at/issues/18296
https://oebl-research.acdh-dev.oeaw.ac.at
MIT License
0 stars 0 forks source link

Add New Lemma Select Lobid Is Wrong Data Type #69

Closed sennierer closed 2 years ago

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Apr 19, 2022, 15:04

Emits string|null instead of array, which is undetected by ts, since it is in Vue, and screws up a whole lot of things, that expect correct data types, because ts …

This also applies to LemmaDetail.

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Apr 19, 2022, 16:27

@sennierer

Some subcomponents are written for gnd?: string, but the data type is gnd: string[]. Now I could change that, to allow multiple gnd selections. But from what I see, maybe it makes more sense, to separate concerns in two fields: gnd?: string and gndSuggestions: string[]?

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Apr 20, 2022, 11:49

mentioned in commit 046408c6bc78681e732300c071adff4550ec86c2

sennierer commented 2 years ago

In GitLab by @PhilipRoeggla on Apr 25, 2022, 14:09

mentioned in commit cfe6578f22e948e17bb84443db868cd55d8024f0