search

acdh-oeaw / arche-core

MIT License
0 stars 1 forks source link

If an error on PUT /{resourceId} happens, the binary stays in the storage location #30

Closed zozlak closed 1 year ago

zozlak commented 1 year ago

Copying file to the target location happens very early

Cleaning of the temp dir on error should be included as well.

zozlak commented 1 year ago

Addressed to some extent by the 80034f4. Can be still vulnerable to errors in Resource::put() but this should be probably handled by the restore() performed by the TransactionController

zozlak commented 1 year ago

Maybe some smart locks from a side db connection would allow to test it...

zozlak commented 1 year ago

Proper tests added by the da50e8541d4888bf87acfef5567dd59e6cce67b1