acdh-oeaw / dhcr-main

Digital Humanities Course Registry Application
https://dhcr.clarin-dariah.eu/
Apache License 2.0
3 stars 0 forks source link

Change default zoom level and center to Europe #103

Closed patrickakk closed 2 months ago

patrickakk commented 3 months ago

@IvdL22 @PixlTracer

In case a user doesn't allow access to their location, the map on the main page is set to a default zoom level and center point. What do you think of changing this to Europe as illustrated in the screenshots below?

Current view

image

New view

image

IvdL22 commented 3 months ago

@patrickakk @PixlTracer I like the proposed view.

patrickakk commented 3 months ago

@IvdL22 Ok, then I'll make the changes. @PixlTracer Do you also agree?

PixlTracer commented 3 months ago

agreed!

patrickakk commented 3 months ago

@IvdL22 @PixlTracer

The feature is ready and can be found here: https://test-dhcr.clarin-dariah.eu/

Can you change the label to Done if satisfied?

Note: Before the change, the user was asked to give access to their location. Since the additional benefit of giving access was small, I've removed this as well. Especially privacy minded users may like this. And the map is already centered on Europe, which covers the majority of courses and users? Feel free the let me know if you think otherwise. The "old" behavior can be found in production.

IvdL22 commented 2 months ago

Thank you @patrickakk

patrickakk commented 2 months ago

Implemented in 2024-06