search

acdh-oeaw / dhcr-main

Digital Humanities Course Registry Application
https://dhcr.clarin-dariah.eu/
Apache License 2.0
4 stars 0 forks source link

Remove sending emails from unit tests #17

Open patrickakk opened 2 years ago

patrickakk commented 2 years ago

Currently emails are sent every time the unit tests are executed, for functions which send emails. Find a way to change this.

dpancic commented 1 year ago

Currently emails are sent every time the unit tests are executed, for functions which send emails. Find a way to change this. That feature was requested by Hendrik. Sending emails after tests can be disabled by updating pipeline config and related environment variables.

patrickakk commented 1 year ago

@dpancic : Do you know why Hendrik requested this?

If I understand it correctly, you mentioned that this (sending mails during the unit tests using the oeaw server) was a bad practice and should be changed?

What do you suggest that we should do?

patrickakk commented 11 months ago

Ask Dalibor again if this is still needed.

The SMTP server changed.