search

acdh-oeaw / dhcr-main

Digital Humanities Course Registry Application
https://dhcr.clarin-dariah.eu/
Apache License 2.0
3 stars 0 forks source link

Number of courses: API vs. DHCR Statistics #63

Closed PixlTracer closed 1 year ago

PixlTracer commented 1 year ago

The number of course counts in the DHCR course statistics dashboard differs from the number of courses retrieved via the API (API overview page - count results)

patrickakk commented 1 year ago

Thanks for creating the issue.

In our meeting on 2023-03-08 we agreed that this will have low priority.

Note: The current numbers are 184 and 186, so the difference is 2 courses. This might have to do with the way in which the course expiration time is calculated. This is done differently in different parts of the application.

patrickakk commented 1 year ago

@PixlTracer @IvdL22

Both API's (v1 and v2) were using an older version of DhcrCore. The older version contained a bug. This caused that unapproved courses were shown in the public registry. This was solved on 2022-10-31 with commit b0636e798e72536eb86cc071313a4bc7d6e77dd9 in DhcrCore

Since yesterday both API's are also using the new version and now the counts in the API are also based on the correct criteria.

https://test-dhcr.clarin-dariah.eu/statistics/course-statistics https://test-dhcr.clarin-dariah.eu/api/v1/courses/count?recent https://test-dhcr.clarin-dariah.eu/api/v2/courses/count?recent

@PixlTracer Can you check if you still experience differences? When not, please change the label to done and write a short line.

patrickakk commented 1 year ago

@IvdL22 @PixlTracer Can you review this?

Please change the label to Done when you're satisfied.

PixlTracer commented 1 year ago

perfect, thank you!

patrickakk commented 1 year ago

Implemented in 2023-02