acdh-oeaw / dhcr-main

Digital Humanities Course Registry Application
https://dhcr.clarin-dariah.eu/
Apache License 2.0
3 stars 0 forks source link

Confusing UI response on instant new user account approval #64

Closed patrickakk closed 1 year ago

patrickakk commented 1 year ago

@IvdL22 @PixlTracer This issue was reported by Iulliana on 2023-03-23.

When clicking the link in the email, for instant approval of a new user account, the message in the user interface is not clear. See attached screenshot.

Although the application works correctly, there are items to check/fix:

dashboard_approve_error

patrickakk commented 1 year ago

development finished.

The error message has been changed to: "Token invalid. Maybe the user is already approved?" The page now immediately redirects to the correct dashboard "Account Approval". There it's possible to check if the user is listed or not.

This can be tested by entering a wrong token, for example: https://test-dhcr.clarin-dariah.eu/users/approve/wrongkey

this can be only be reviewed after the current version (2023-02) is released.

currently blocked

patrickakk commented 1 year ago

@IvdL22 @PixlTracer Can you review this?

Please change the label to Done when you're satisfied.

patrickakk commented 1 year ago

Implemented in 2023-03