Closed patrickakk closed 11 months ago
As well the map on the main pages uses Leaflet:
Other mapping frameworks
If you are using Mapbox maps with another open source library, like Leaflet or OpenLayers, the Mapbox logo and attribution are still required. These libraries may not automatically add necessary attribution, so you'll need to add it yourself. To get the Mapbox logo in various formats and styles, download the Mapbox logo file on our Press page.
@vronk FYI, see above.
@PixlTracer @IvdL22
Can you review this?
Available at the "main page" in test: https://test-dhcr.clarin-dariah.eu/
@patrickakk Sorry, Patrick, I am sorry, how exactly do I need to test/review this? I see the attribution and the map seems to work fine.
@IvdL22 Yes, it's only about the attribution. The quotes and link in the first comment of this issue explain that attribution is required when using their services. The attribution was not added to the application in the past.
I've tried to implement it in the way described in the documentation.
Please let me know when something is missing and maybe ask others involved in the project as well @PixlTracer @vronk .
If we all agree that it's implemented the way it should, then we can mark this issue as "Done" ?
checked the map and it is fine, the logo and the mini text are not bothering at all;
one minor thing: when entering the main page in dev, the map is cropped (see screenshot below); can the map be 'more zoomed in'? then the grey cropping disappears;
(if this cannot be resolved easily, please close the issue)
@PixlTracer I've created a separate issue for this question, since that might require some more investigating.
Then we can close this issue and release the version.
Implemented in 2023-09.
The current map on the main page uses styles hosted on Mapbox. According their documentation, attribution is required: https://docs.mapbox.com/help/getting-started/attribution/