acdh-oeaw / dhcr-main

Digital Humanities Course Registry Application
https://dhcr.clarin-dariah.eu/
Apache License 2.0
3 stars 0 forks source link

Make clear difference between user roles at User->Edit page #79

Closed patrickakk closed 7 months ago

patrickakk commented 11 months ago

Currently the items for moderator and administrator roles are listed together. This can be confusing.

Change the layout so they are better separated.

patrickakk commented 9 months ago

The screenshot below shows the current (before) layout of the User->Edit page.

image

patrickakk commented 9 months ago

New layout:

image

patrickakk commented 9 months ago

@IvdL22 @PixlTracer Can you review this?

As of the next day (tomorrow) it should be visible in the test instance. (At the usual url)

Is the new layout clear and can it avoid mistakes when assigning user rights?

Can you change the label to Done if satisfied?

IvdL22 commented 8 months ago

@patrickakk and @PixlTracer fyi: The new layout looks good. For consistency, you could write out _User administrator. What is the difference between ''administrator rights'' and ''user administrator''? I thought that one who has administrator rights automatically gets also user administrator rights. But I might be wrong.

patrickakk commented 8 months ago

@IvdL22 You didn't change the label to Done?

In this case I would suggest not to write out "User administrator".

What is the difference between ''administrator rights'' and ''user administrator''?

This situation exists because some legacy and changes to the application made in the past. Currently both checkboxes are needed to check/uncheck, as described in the note. So it's already explained?

Right now we can choose to invest additional working hours in refactoring the application, so that only one checkbox remains. Or, we avoid those extra hours, and You and Anna just check or uncheck both check-boxes when a change is made? What do you think?

PixlTracer commented 7 months ago

dear both, I am ok with checking both boxes; Iulianna, if this ok for you too, please change the label to 'done'

patrickakk commented 7 months ago

Implemented in 2023-11