search

acdh-oeaw / dse-static-cookiecutter

Cookiecutter template for a Static-Site Digital Scholarly Edition
7 stars 4 forks source link

dse-static-site Project Generator defaults preventing successful completion of Quickstart guide #56

Closed dominikfill closed 5 months ago

dominikfill commented 8 months ago

Hi,

Step 12/14 of the dse-static-site project generator consists of selecting the search_engine. The default value provided is set to typesense.

Accepting this default value makes completing the step

https://github.com/acdh-oeaw/dse-static-cookiecutter/blob/76853bd1bf82ba731dd5807123221ca1f9c5c01b/README.md?plain=1#L33

of the Quickstart guide impossible, as choosing typesense deletes build_index.sh, as defined in hooks/post_gen_project.py

https://github.com/acdh-oeaw/dse-static-cookiecutter/blob/76853bd1bf82ba731dd5807123221ca1f9c5c01b/hooks/post_gen_project.py#L10-L16

This could maybe cause confusion for new users, as one could expect that using the defaults provided would allow for successful completion of the Quickstart guide.

csae8092 commented 8 months ago

Thanks for using/trying Out dse-cookie-cutter! I'll look into it the next couple of days

csae8092 commented 5 months ago

staticSearch support dropped, therefore this issue should be resolved