stefanprobst
commented
1 year ago decisions:
TODO:
(2) remove search options dialog. place "include data" select and "query mode" select more prominently below autocomplete.
DONE
(3) keep as is.
(4) x-ref https://github.com/acdh-oeaw/mmp-frontend/issues/94
(5) solved by combining graph components.
(1)
currently, search requests must always be dispatched explicitly by clicking the "magnifying glass" button. e.g. adjusting the date range slider, will not by itself dispatch a new request. similarly, when clicking a keyword "chip" in the list view, or in a details panel, the selected keyword will be added to the search autocomplete, but will not dispatch a search request (EDIT: however, in the "list all entities" screen, clicking an entity will dispatch a search request). the same is true for adjusting the search options, e.g. changing the query mode from "intersection" to "union".
are we happy with this behavior? or should we change to dispatch requests "on change", not "on submit"?
(2)
currently, the search form allows setting some basic search options. one of those settings is selecting specific entity types:
however, while it may seem that this allows configuring which entity types will be included in the result set, this actually just configures which entity types will be excluded from the options displayed in the autocomplete dropdown -- which is an unusual pattern for search UI.
i would vote for removing this config, and generally making clearer that search will always return passages (i.e. entities of type
stelle). for example the autocomplete placeholder text should not read "Search for Authors, Passages, Keywords, Case Studies, or Places". similarly, the initial help text with recommended search terms should not read "Search our database for medieval authors, passages, keywords (such as names of peoples) or case studies."afaiu by default, search always returns a filtered set of passages (or spatial coverages associated with a passage in the map view, or keywords associated with a passage in the graph/wordcloud view). it is only possible to search for other entity types via the dedicated "List all entities" screen, which has a different, non-configurable search form.
(3)
currently it is possible to search over multiple selected case studies - do we want to keep this? there is also some tension between these search views, and the dedicated case study entry point
(4)
it's not totally clear that some of the search config settings affect not only the main search form, but other requests as well - e.g. requests in the detail panels will respect the
has_usecasesetting.(5)
the search autocomplete also doubles as an "author" select for the compare authors graph