acdh-oeaw / vicav-vue3

Reimplementation of the VICAV Frontend based on Vue.js 3
https://vicav-vue.acdh-ch-dev.oeaw.ac.at
MIT License
0 stars 0 forks source link

Corpus query and text components #29

Closed MauPalantir closed 7 months ago

MauPalantir commented 1 year ago
Képernyőfotó 2023-07-22 - 17 06 37

This depends on https://github.com/acdh-oeaw/vicav-app-api/pull/1

ctot-nondef commented 1 year ago

components refactored to use composition API - untested d/t lack of menu points

ctot-nondef commented 1 year ago

@MauPalantir Thank you for these contributions! I ported your code to use Vues composition API, which we're trying to use throughout the project. This brings a couple of changes in how to set up reactivity etc but makes typing much easier and flexible.

A couple of points to implement:

MauPalantir commented 1 year ago

Implemented proper text loading and scrolling for UI. Left from feedback is the refactoring to use useAsyncData.

ctot-nondef commented 7 months ago

in order to merge this, we should replace the custom scss styling in corpus-text-window-content.vue with tailwind styling