search

acdh-oeaw / vicav-vue3

Reimplementation of the VICAV Frontend based on Vue.js 3
https://vicav-vue.acdh-ch-dev.oeaw.ac.at
MIT License
0 stars 0 forks source link

Let's please use our usually used CI/CD pipeline #56

Closed simar0at closed 1 year ago

simar0at commented 1 year ago

I got your branch to work with some effort on our usually used CI/CD pipeline.
https://next-ci-cd.acdh-cluster-2.arz.oeaw.ac.at/ At least for this project I want to use this approach and not have a custom build pipeline or Dockerfile.

stefanprobst commented 1 year ago

this is missing some build args for the docker image (e.g. the redmine service id for the imprint service via NUXT_PUBLIC_REDMINE_ID)

also, if generating the preview deployment relies on branch naming conventions (see https://github.com/acdh-oeaw/vicav-vue3/pull/56/commits/41b9f19eebecb417d8a73a7bef1def590fb6dccb) these should be documented somewhere?

may i ask what was not working in the current build-deploy.yml?

simar0at commented 1 year ago

this is missing some build args for the docker image (e.g. the redmine service id for the imprint service via NUXT_PUBLIC_REDMINE_ID)

If you need that (I don't) you can add whatever environment variable is necessary in the GitHub variables as K8S_SECRET_A_VAR with my process. So e.g. K8S_SECRET_NUXT_PUBLIC_REDMINE_ID also, if generating the preview deployment relies on branch naming conventions (see 41b9f19) these should be documented somewhere?

This is some of the first projects that use that so a documentation is missing. A part of that documentation is probably just the code in starter.yaml that creates that. may i ask what was not working in the current build-deploy.yml?

I don't have time to maintain it and it is invented in house and not used by many more institutions on the internet.
The standard workflow is used by a lot of people at heroku, some more that bought into gitlab AutoDevOps and I think some more. Many more eyes probably catch more errors.

stefanprobst commented 1 year ago

I don't have time to maintain it and it is invented in house

i mean all it does is clean up the starter.yaml config and use a pretty standard Dockerfile to build the docker image