acdh-oeaw / vocabseditor

Vocabseditor is a web-based tool for collaborative work on controlled vocabularies development
https://vocabseditor.acdh.oeaw.ac.at/
MIT License
23 stars 6 forks source link

Export ignores language titles for concept scheme rdfs:label #64

Open KlausIllmayer opened 1 year ago

KlausIllmayer commented 1 year ago

When serializing a conceptScheme then for the titles a dc:title and an rdfs:label is created. Surprisingly, whereas different language titles are respected for dc:title, only one title is taken for rdfs:label. I can't see why this would make sense.

Example: you have a conceptScheme where in vocabseditor you defined a dc:title in English, e.g. "Example"@en and one in German, e.g. "Beispiel"@de. When serialising it will create additionally a rdfs:label (which is fine and should stay) but only with one of the titles for rdfs:label (I guess it takes the first that it finds in the database).

Looking in the code it seems that moving https://github.com/acdh-oeaw/vocabseditor/blob/master/vocabs/rdf_utils.py#L46 after https://github.com/acdh-oeaw/vocabseditor/blob/master/vocabs/rdf_utils.py#L49 should do the trick (and removing afterwards the lines 44-46). Could this work?