search

acdh-oeaw / wboe-redaktionstool

MIT License
0 stars 0 forks source link

Fehler duplicate "fileDesc" in Redaktionstool #59

Closed simar0at closed 1 year ago

simar0at commented 4 years ago

In GitLab by @iljackb on Feb 5, 2020, 15:51

There is are the following error in several files when opened in the redaktionstool browser:

"-fileDesc - Tag "fileDesc" enthält Fehler! -Kinder: Tag "revisionDesc: nicht erwartet" and " -revisionDesc -Postion:Tag "fileDesc" sollte statt "fileDesc" voher stehen! (vpe)"

See files: facken_facknen.xml, (ge)flimmern.xml, (ge)flinsig.xml, and surely others...

When examined, it appears that the is copied twice which is the problem. (see bottom of issue for example copied from file)

However, the strangest part is that when I open the same file in Oxygen (which I synced to make sure), this extra <fileDesc> is not there and the header is perfectly fine!

(see from facken_facknen.xml in Redaktionstool.xml)

    <fileDesc>
      <titleStmt>
        <title></title>
        <respStmt>
          <resp>Editor</resp>
          <name></name>
        </respStmt>
        <respStmt>
          <resp>Encoding Scheme</resp>
          <name>Jack Bowers</name>
          <name>Daniel Schopper</name>
          <name>Omar Siam</name>
        </respStmt>
        <respStmt>
          <resp>DBOE Team</resp>
          <name xml:id="AL">Alexandra N. Lenz</name>
          <name xml:id="PhS">Philipp Stöckle</name>
          <name xml:id="AG">Andreas Gellan</name>
          <name xml:id="PZ">Patrick Zeitlhuber</name>
          <name xml:id="SW">Sabine Wahl</name>
          <name xml:id="SS">Sonja Schwaiger</name>
          <name xml:id="AB">Angela Bergermayer</name>
          <name xml:id="EW">Eva Wahlmüller</name>
          <name xml:id="DG">David Gschösser</name>
        </respStmt>
        <respStmt>
          <resp>Student assistants</resp>
          <name>Susanna Muhr</name>
          <name>Manuela Stütz</name>
          <name>Christina Hemetsberger</name>
        </respStmt>
      </titleStmt>
      <publicationStmt>
        <p></p>
      </publicationStmt>
      <sourceDesc>
        <list>
          <item>
            <label>Geo-data</label>
            <ptr xml:id="geo-inventory-WBOE" target="../geodata-wboe.xml"/>
          </item>
          <item>
            <label>Bibliography</label>
            <ptr xml:id="bibliography-WBOE" target="../bibl-wboe.xml"/>
          </item>
          <item>
            <label>WBOE-Slips</label>
            <ptr xml:id="slips-WBOE" target="../slips-wboe.xml"/>
          </item>
          <item>
            <label>WBOE-Collections</label>
            <ptr xml:id="collections-WBOE" target="../collections-wboe.xml"/>
          </item>
        </list>
      </sourceDesc>
    </fileDesc>
    <fileDesc>
      <titleStmt>
        <title>facken, facknen</title>
        <respStmt>
          <resp>Editor</resp>
          <name ref="#PhS">Philipp Stöckle</name>
        </respStmt>
        <respStmt>
          <resp>Encoding Scheme</resp>
          <name>Jack Bowers</name>
          <name>Daniel Schopper</name>
          <name>Omar Siam</name>
        </respStmt>
        <respStmt>
          <resp>DBOE Team</resp>
          <name xml:id="AL">Alexandra N. Lenz</name>
          <name xml:id="PhS">Philipp Stöckle</name>
          <name xml:id="AG">Andreas Gellan</name>
          <name xml:id="PZ">Patrick Zeitlhuber</name>
          <name xml:id="SW">Sabine Wahl</name>
          <name xml:id="SS">Sonja Schwaiger</name>
          <name xml:id="JD">Jan Braun</name>
          <name xml:id="AB">Angela Bergermayer</name>
          <name xml:id="EW">Eva Wahlmüller</name>
        </respStmt>
        <respStmt>
          <resp>Student assistants</resp>
          <name>Eva Wahlmüller</name>
          <name>Susanna Muhr</name>
          <name>Alexandra Grohe</name>
          <name>Klemens Wagner</name>
        </respStmt>
      </titleStmt>
      <publicationStmt>
        <p></p>
      </publicationStmt>
      <sourceDesc>
        <list>
          <item>
            <label>Geo-data</label>
            <ref xml:id="geo-inventory-WBOE" target="../geodata-wboe.xml"></ref>
          </item>
          <item>
            <label>Bibliography</label>
            <ref xml:id="bibliography-WBOE" target="../bibl-wboe.xml"></ref>
          </item>
          <item>
            <label>WBOE-Slips</label>
            <ref xml:id="slips-WBOE" target="../slips-wboe.xml"></ref>
          </item>
          <item>
            <label>WBOE-Collections</label>
            <ref xml:id="collections-WBOE" target="../collections-wboe.xml"></ref>
          </item>
        </list>
      </sourceDesc>
      <revisionDesc status="unfinished">
        <change status="unfinished" when="2018-10-26" who="PhS">Datensatz erstellt</change>
      </revisionDesc>
    </fileDesc>

(see example from facken_facknen.xml opened in oxygen)

     <fileDesc>
        <titleStmt>
           <title>facken, facknen</title>
           <respStmt>
              <resp>Editor</resp>
              <name ref="#PhS">Philipp Stöckle</name>
           </respStmt>
           <respStmt>
              <resp>Encoding Scheme</resp>
              <name>Jack Bowers</name>
              <name>Daniel Schopper</name>
              <name>Omar Siam</name>
           </respStmt>
           <respStmt>
              <resp>DBOE Team</resp>
              <name xml:id="AL">Alexandra N. Lenz</name>
              <name xml:id="PhS">Philipp Stöckle</name>
              <name xml:id="AG">Andreas Gellan</name>
              <name xml:id="PZ">Patrick Zeitlhuber</name>
              <name xml:id="SW">Sabine Wahl</name>
              <name xml:id="SS">Sonja Schwaiger</name>
              <name xml:id="JD">Jan Braun</name>
              <name xml:id="AB">Angela Bergermayer</name>
              <name xml:id="EW">Eva Wahlmüller</name>
           </respStmt>
           <respStmt>
              <resp>Student assistants</resp>
              <name>Eva Wahlmüller</name>
              <name>Susanna Muhr</name>
              <name>Alexandra Grohe</name>
              <name>Klemens Wagner</name>
           </respStmt>
        </titleStmt>
        <publicationStmt>
           <p></p>
        </publicationStmt>
        <sourceDesc>
           <list>
              <item>
                 <label>Geo-data</label>
                 <ref xml:id="geo-inventory-WBOE" target="../geodata-wboe.xml"></ref>
              </item>
              <item>
                 <label>Bibliography</label>
                 <ref xml:id="bibliography-WBOE" target="../bibl-wboe.xml"></ref>
              </item>
              <item>
                 <label>WBOE-Slips</label>
                 <ref xml:id="slips-WBOE" target="../slips-wboe.xml"></ref>
              </item>
              <item>
                 <label>WBOE-Collections</label>
                 <ref xml:id="collections-WBOE" target="../collections-wboe.xml"></ref>
              </item>
           </list>
        </sourceDesc>
        <revisionDesc status="unfinished">
           <change status="unfinished" when="2018-10-26" who="PhS">Datensatz erstellt</change>
        </revisionDesc>
     </fileDesc>
simar0at commented 4 years ago

In GitLab by @hcbreuer79 on Feb 5, 2020, 19:24

Das sind alte Dateien die noch nicht in's neuen Schema umgewandelt wurden. Das revisionDesc ist nicht mehr im fileDesc. Siehe https://gitlab.com/acdh-oeaw/wboe/artikel/-/blob/master/wboe-article-template.xml#L53-58

  <teiHeader>
    <fileDesc>
      <titleStmt>
        <title>facken, facknen</title>
        <respStmt>
          <resp>Editor</resp>
          <name ref="#PhS">Philipp Stöckle</name>
        </respStmt>
        <respStmt>
          <resp>Encoding Scheme</resp>
          <name>Jack Bowers</name>
          <name>Daniel Schopper</name>
          <name>Omar Siam</name>
        </respStmt>
        <respStmt>
          <resp>DBOE Team</resp>
          <name xml:id="AL">Alexandra N. Lenz</name>
          <name xml:id="PhS">Philipp Stöckle</name>
          <name xml:id="AG">Andreas Gellan</name>
          <name xml:id="PZ">Patrick Zeitlhuber</name>
          <name xml:id="SW">Sabine Wahl</name>
          <name xml:id="SS">Sonja Schwaiger</name>
          <name xml:id="JD">Jan Braun</name>
          <name xml:id="AB">Angela Bergermayer</name>
          <name xml:id="EW">Eva Wahlmüller</name>
          <name xml:id="DG">David Gschösser</name>
        </respStmt>
        <respStmt>
          <resp>Student assistants</resp>
          <name>Eva Wahlmüller</name>
          <name>Susanna Muhr</name>
          <name>Alexandra Grohe</name>
          <name>Klemens Wagner</name>
          <name>Manuela Stütz</name>
          <name>Christina Hemetsberger</name>
        </respStmt>
      </titleStmt>
      <publicationStmt>
        <p></p>
      </publicationStmt>
      <sourceDesc>
        <list>
          <item>
            <label>Geo-data</label>
            <ptr xml:id="geo-inventory-WBOE" target="../geodata-wboe.xml"/>
          </item>
          <item>
            <label>Bibliography</label>
            <ptr xml:id="bibliography-WBOE" target="../bibl-wboe.xml"/>
          </item>
          <item>
            <label>WBOE-Slips</label>
            <ptr xml:id="slips-WBOE" target="../slips-wboe.xml"/>
          </item>
          <item>
            <label>WBOE-Collections</label>
            <ptr xml:id="collections-WBOE" target="../collections-wboe.xml"/>
          </item>
        </list>
      </sourceDesc>
    </fileDesc>
    <revisionDesc>
      <listChange>
        <change status="unfinished" when="2020-02-05" who="#AL">Datensatz erstellt</change>
      </listChange>
    </revisionDesc>
  </teiHeader>
simar0at commented 4 years ago

In GitLab by @iljackb on Feb 6, 2020, 12:55

@Phil_ACDH @andreas.gellan could one of you open the files: facken_facknen.xml, (ge)flimmern.xml, (ge)flinsig.xml, Fabrik.xml both in Oxygen and the editor tool? I am seeing different versions of the files (the one in the Redaktionstool has 2 <fileDesc> and the one in Oxygen doesn't (because I edited it).)

If you see this difference also, there is a possible error in the tool, or at least it doesn't seem to be pulling updates from Git..

simar0at commented 4 years ago

In GitLab by @Phil_ACDH on Feb 10, 2020, 12:13

Hi @iljackb and @hcbreuer79, I just opened the four articles in two versions of the Redaktionstool, 0.4.36 and 0.5.18

In the older version (0.4.36) the tag appeared only once, in the new version (0.5.18) it appeared twice ...! Does that help?

simar0at commented 4 years ago

In GitLab by @Phil_ACDH on Feb 19, 2020, 12:16

Lieber @hcbreuer79, könntest du da nochmal einen Blick drauf werfen? Wenn man die entsprechenden Artikel (z.B. facken_facknen) in einem Editor (Oxygen, Notepad++, ...) öffnet, erscheint der Tag nur einmal, öffnet man denselben Artikel im Redaktionstool (Version 0.5.19), erscheint zweimal.
Weißt du, woran das liegt? Offenbar ist es für die Konvertierung der alten Artikel relevant. Danke!

simar0at commented 4 years ago

In GitLab by @hcbreuer79 on Feb 19, 2020, 12:54

Wie gesagt es kommt weil revisionDesc sich bei den alten Dateien im fileDesc befindet.\ Die müssen umgewandelt werden, also es muss image\ in\ image\ abgeändert werden!\ \ Desweiteren muss sense beachtet werden:\ image\ zu image\ \ Ich habe das jetzt beispielhaft mal bei facken_facknen.xml gemacht: https://gitlab.com/acdh-oeaw/wboe/artikel/-/commit/924d4526b72d99d8baccffc0692be571171da6db

simar0at commented 4 years ago

In GitLab by @iljackb on Feb 19, 2020, 14:12

OK, I do understand those things need to be updated (I'm going to run the script tomorrow)... but fixing these issues still didn't fix the problem of seeing the two instances of <fileDesc>, and the same errors about fileDesc.

Also, I didn't mention this before but there are also two consective instances of <revisionStmt> that only appear in the Redatktionstool

See here for the version visible in the Redaktionstool XML Editor view (two <revisionStmt>'s:

fahrnis_revisionStmnt

See here for the version as opened in Oxygen XML Editor (only one <revisionStmt>: Fahnis-revision-Oxygen

I just took the article Fahrnis.xml and updated all of these features and the problem is still there in the Editor, the only errors still there are the following:

"-fileDesc - Tag "fileDesc" enthält Fehler! -Kinder: Tag "revisionDesc: nicht erwartet" and " -revisionDesc -Postion:Tag "fileDesc" sollte statt "fileDesc" voher stehen! (vpe)"

If those issues (e.g. wrapping <sense> (both in <entry> and <re>) and the need for <listChange> in <revisionDesc>) are the causes of all of the errors:

  1. Why does the error message continue to be shown?
  2. Why is there still two consecutive instances of <fileDesc> visible only in the editor tool and not the file itself?

It seems that until this issue is fixed, even when I update the file formats for <sense> and <listChange> they still won't be visible outside of the XML view.

See here for proof of correct formatting of in <entry> level, and in <re> level (both visible in the Redaktionstool XML Editor view):

fahrnis-sense

fahrnis-re-sense

simar0at commented 4 years ago

In GitLab by @hcbreuer79 on Feb 19, 2020, 15:40

Ich brauche deine aktualisierte Fahrnis.xml Datei um dir sagen zu können woran es liegt.

simar0at commented 4 years ago

In GitLab by @iljackb on Feb 19, 2020, 15:53

Fahrnis.xml

simar0at commented 4 years ago

In GitLab by @hcbreuer79 on Feb 19, 2020, 16:01

@iljackb revisionDesc ist noch in fileDesc statt darunter.\ image

simar0at commented 4 years ago

In GitLab by @iljackb on Feb 19, 2020, 17:10

@hcbreuer79 kurios, in meinem (offen in Oxygen XML editor, siehe Bild und angehängte Datei) revisionDesc ist es tatsächlich in fileDesc! Was das Redaktionstool anzeigt, ist also nicht dasselbe wie die Dateien, wenn es außerhalb des Programms geöffnet wird

Fahrnis.xml

Fahnis-revision-Oxygen

simar0at commented 4 years ago

In GitLab by @hcbreuer79 on Feb 19, 2020, 17:18

@iljackb Es darf nicht in fileDesc sein!\ Es ist sinnvoll im Redaktionstool "Änderungen anzeigen" zu aktivieren! Dann wird angezeigt was sich an der Datei seit dem laden bzw. letzen speichern geändert hat.\ image

simar0at commented 4 years ago

In GitLab by @iljackb on Feb 19, 2020, 17:45

@hcbreuer79 Du hast rechts, revisionDesc darf nicht in fileDesc sein.. Und Ich habe es in die Datei verschoben und jetzt es funktioniert ohne Fehler im Redaktionstool! Danke

simar0at commented 4 years ago

In GitLab by @hcbreuer79 on Feb 19, 2020, 18:11

Sehr gut ... dann schließe ich jetzt den Issue. ;-)

simar0at commented 4 years ago

In GitLab by @hcbreuer79 on Feb 19, 2020, 18:11

closed