search

acdlite / flummox

Minimal, isomorphic Flux.
http://acdlite.github.io/flummox
1.69k stars 114 forks source link

Remove Actions class #235

Closed acdlite closed 9 years ago

acdlite commented 9 years ago

@johanneslumpe Please review and let me know if I missed anything in the tests. Hopefully they don't conflict too much with yours. Other than the tests specifically related to actions, most of the edits involve changing class TestActions extends Actions {} to const TestActions = {}.

johanneslumpe commented 9 years ago

Apart from my comments above it seems good to me. Merging also does not seem to pose an issue - according to the compare feature on GitHub. I'd say we first merge this in, and then merge in my works + the other 4.0-tagged PRs.

Except the argument passing to dispatch I've already changed all the things I commented on in #236. Feel free to merge it into this branch or tell me if you think something doesn't feel right :)