search

acdlite / redux-router

Redux bindings for React Router – keep your router state inside your Redux store
MIT License
2.3k stars 200 forks source link

react-router can't be resolved #111

Closed farin closed 9 years ago

farin commented 9 years ago

using with webpack, getting

ERROR in ./~/redux-router/lib/isActive.js Module not found: Error: Cannot resolve module 'react-router/lib/isActive' in .../node_modules/redux-router/lib @ ./~/redux-router/lib/isActive.js 8:30-66

farin commented 9 years ago

seems to be duplicate to #91

guocheng commented 8 years ago

I had the same issue, how did you solve it?

I tried npm install --save redux-router@1.0.0-beta3 but it still gives me the error.

Here are the packages I have installed:

react-router@0.13.5 redux-router@1.0.0-beta3 react@0.14.2 react-redux@4.0.0 react-router@0.13.5

UPDATE: install the latest version of redux-router is not enough, I had to installed the latest version of react-router as well to solve this issue:

npm install history react-router@latest

This bumped my react-router version from 0.13.5 to 1.0.0-rc4

wtfil commented 8 years ago

Having the same issue with redux-router@1.0.0-beta3 and redux-router@1.0.0-beta4

Error: module "react-router/lib/isActive" not found from "<project-root>/node_modules/redux-router/lib/isActive.js"

I found this one https://github.com/rackt/redux-router/blob/master/src/isActive.js#L1 but there is no react-router in dependencies (or peerDependencies)

Scarysize commented 8 years ago

@wtfil which react-router version do have installed?

wtfil commented 8 years ago

@Scarysize In general I have not react-router in packages.json (I killed it in favor of redux-router ) but I found it in node_modules. There is a react-router@1.0.0-beta3. I killed it for clear experiment and then I got this error Error: module "react-router" not found from "<project-root>/node_modules/redux-router/lib/ReduxRouter.js"

Now I understood that redux-router is depend on react-router but this should be reflected in package.json either in dependencies or peerDependencies. I can create a PR with this small fix.

monarchwadia commented 8 years ago

Fixed this issue using @guocheng 's updated answer above (ran this command: npm install --save history react-router@latest followed by npm install --save redux-router@1.0.0-beta3 )

joshuakfarrar commented 8 years ago

+1 just ran into this, thank you for the notes