search

acdlite / redux-router

Redux bindings for React Router – keep your router state inside your Redux store
MIT License
2.3k stars 200 forks source link

createLocation can only be called through an instance of history #114

Closed apapirovski closed 8 years ago

apapirovski commented 9 years ago

I didn't see a clean way of doing history.createLocation within the matchMiddleware so src/server.js is now responsible for createLocation, as well as match. Addresses #102.

Let me know if you want me to make any changes to this.

apapirovski commented 9 years ago

I've added a test-case for this that checks for query in server-side rendering. Currently fails but with createLocation as an instance of history, it passes. Addresses #106.

apapirovski commented 9 years ago

createLocation has been un-deprecated but this still solves the query issue which is IMO valuable.

addnab commented 9 years ago

Any update about his PR?

addnab commented 8 years ago

@omnidan

omnidan commented 8 years ago

@addnab Thanks for pinging me :smiley:

Looks good to me, I'll merge this :+1:

frankleng commented 8 years ago

anyone know when the next release will be cut that will include this fix?

omnidan commented 8 years ago

@frankleng I talked to @acdlite and he'll try to do it today :smile:

addnab commented 8 years ago

@apapirovski @omnidan Thanks. Hope this gets released soon.

omnidan commented 8 years ago

@addnab this should be in beta4 which @acdlite recently released :smile: