Closed apapirovski closed 8 years ago
I've added a test-case for this that checks for query in server-side rendering. Currently fails but with createLocation as an instance of history, it passes. Addresses #106.
createLocation
has been un-deprecated but this still solves the query issue which is IMO valuable.
Any update about his PR?
@omnidan
@addnab Thanks for pinging me :smiley:
Looks good to me, I'll merge this :+1:
anyone know when the next release will be cut that will include this fix?
@frankleng I talked to @acdlite and he'll try to do it today :smile:
@apapirovski @omnidan Thanks. Hope this gets released soon.
@addnab this should be in beta4
which @acdlite recently released :smile:
I didn't see a clean way of doing
history.createLocation
within the matchMiddleware so src/server.js is now responsible for createLocation, as well as match. Addresses #102.Let me know if you want me to make any changes to this.