search

acdlite / redux-router

Redux bindings for React Router – keep your router state inside your Redux store
MIT License
2.3k stars 200 forks source link

Extraneous history 1.9 #187

Closed maitriyogin closed 8 years ago

maitriyogin commented 8 years ago

Hi, I'v tightened up my git hooks and noticed while validate ( npm ls ) I get the following : npm ERR! extraneous: history@1.9.0 /Users/stephenwhite/Documents/Projects/telenor/cc20/appboard/node_modules/redux-router/node_modules/history

React router 1.0.0 post installs history 1.13.1. Redux router deps on react router 1.0.0b3 which curiously depends on history 1.12 ....

Any chance you guys could bump the history dep ? When running my app everything works as expected, it's just the npm ls which moans ... Cheers, Stephen.

Scarysize commented 8 years ago

yep, there is something in progress. Maybe adding history as a peerDependcy, like react-router does.

maitriyogin commented 8 years ago

hmm tried this 

"peerDependencies": {
    "history": "^1.13.1"
  },

get the same extraneous ... error

SimenB commented 8 years ago

There was a bug i npm always including history package in npm tarball. Might need new publish?

npm/npm#9894

datoml commented 8 years ago

Can confirm this. npm includes "history": "^1.9.0".

yookoala commented 8 years ago

I think 4d02c6b got this covered.

Scarysize commented 8 years ago

@yookoala Yep, thanks for keeping track!