search

acdlite / redux-router

Redux bindings for React Router – keep your router state inside your Redux store
MIT License
2.3k stars 200 forks source link

Add react-router to peerDependencies #188

Closed peteobrien closed 8 years ago

peteobrien commented 8 years ago

Assuming the requirement is for 1.+ (I don't know as to minimum requirement), this could be added to package.json

  "peerDependencies": {
    "react-router": "^1.0.0"
  }
Scarysize commented 8 years ago

Hey, I think this would complement 139ddd4b289dc39d4576dfb0241391192979e584. Looking into it!

ReactiveRaven commented 8 years ago

Hi, I ran into this problem too when installing via jspm. I was getting errors complaining react-router isn't installed when developing/bundling. Adding to dependencies would solve this.

Is there a reason dependencies are marked as devDependencies? For example react, react-redux, and react-router are all required in the first three lines of redux-router/src/ReduxRouter.js but are all marked as devDependencies in package.json, so would not be installed on a clean jspm install redux-router.