Closed tlrobinson closed 8 years ago
I see, we got a dependency on an older version of history (1.12). You may try updating to npm v3.
A lot of people are still using npm 2. Is there another workaround?
+1 people and production servers are still using npm 2.
Here's what I found.
history@1.13.1 is included in redux-router@1.0.0-beta5 npm package inside. I think history module should be installed by npm install, not from the package. You can find out by uncompressing cache file from ~/.npm/redux-router/1.0.0-beta5/package.tgz once after install.
I think this might be the same issue I ran into previously here: https://github.com/rackt/redux-router/issues/54 which ended up being an npm issue https://github.com/npm/npm/issues/9642.
The issue I think is that the bug is still present in npm3. This is a problem because this happens when this package is published by npm3 since npm is including node_modules/history
in the tarball, so it doesn't matter if you are consuming it using npm2.
I've been using a workaround where I just rimraf node_modules/redux-router/history
since its not needed, but I'm not sure if that will work when shrinkwrapping (all I'm doing is running npm ls
to validate that my package.json and node_modules are in sync).
So basically we got either people having problems with shrink-wrap (if history is just a devDependency) or people having problems with older npm versions (if history is a dependency).
Any advice to satisfy both needs is welcome! I don't have an immediate solution and also that really not the time to test for different npm versions.
Until NPM fixes bug, we can make publish script like
rimraf node_modules/history; npm publish; npm install
Ugly and disappointing...
We are in the process of eliminating history
as a dependency.
On a side note: the npm bug with the history
module is fixed.
I'm not really sure what's going on here, but I'm unable to shrinkwrap a project containing redux-router 1.0.0-beta5 due to this error:
npm ls
shows there's an issue with thehistory
dependency:I'm on npm v2.14.14.