search

acdlite / redux-router

Redux bindings for React Router – keep your router state inside your Redux store
MIT License
2.3k stars 216 forks source link

TypeScript Support #211

Closed remojansen closed 8 years ago

remojansen commented 8 years ago

Hi guys,

Sorry if this is not the right place to ask for help but I was trying to use redux-router with TypeScript but there are not type definitions available for it.

I have created an early version of the redux-router.d.ts file which is available at:

https://gist.github.com/remojansen/2aec9b2c63f70787d805

I would like to ask for help to the Rackt community to complete the full type definitions.

You can use the react-router as reference:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/react-router/react-router.d.ts

Thanks,

Remo

Scarysize commented 8 years ago

I think this is currently out of the scope of this project. If you are still up to providing full typescript support, we can reopen this.

stepancar commented 8 years ago

@remojansen as i understand it's not pushed to https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/ do you have any not merged pull request?

remojansen commented 8 years ago

@stepancar I didn't have time to complete the type definitions so I didn't do a PR

stepancar commented 8 years ago

@remojansen i pushed definitions

remojansen commented 8 years ago

@stepancar :+1: thanks a lot for that!