Closed mjrussell closed 8 years ago
Maybe see if we can come up with a test for this.
@Scarysize Yeah I wanted a decent test but the only thing I could think of was to export the ReduxRouterContext
component and just test if the location prop is undefined or null that it renders null.
It seemed a little gimmicky, but I could definitely make that. I wonder if its just better to have 2 examples in the repo, one for regular routes and one for async, lazy loading routes (even though its really just following react-router
's API.
Yeah, okay examples seem to be a good way to display what this changes makes possible.
Fully finishing the work done in #202
react-router
is able to just check null because it checks against its initial state, but the prop unpacking using spread syntax will make the location set toundefined
inReduxRouterContext
Noticed that @yesmeck pointed this out