Updates Redux-Router to React-Router V2

acdlite / redux-router

Redux bindings for React Router – keep your router state inside your Redux store

MIT License

2.3k stars 200 forks source link

Updates Redux-Router to React-Router V2 #245

Closed mjrussell closed 8 years ago

mjrussell commented 8 years ago

Resolves #227

Sorry this has been in an 80% state for so long, just want to get it out there so if others want to help moving it along/provide feedback they can.

Remaining outstanding items:

[x] isActive test to pass (waiting on https://github.com/reactjs/react-router/pull/3206)

README updates:

[x] Remove old references to replaceState and pushState to follow history API
[x] Update code example in README
[x] Link back to redux-router v1 README if necessary

levrik commented 8 years ago

I can update the README tonight :wink:

mjrussell commented 8 years ago

@DerNivel that would be very helpful! Thanks

mjrussell commented 8 years ago

@Scarysize I just rebased/resolved conflicts after @DerNivel's updates. This should be good to go (and all the tests pass locally). I think it would be good to either merge to master or branch soonish and get a beta release out there.

Scarysize commented 8 years ago

I guess we will just merge it into master. The last version before react-router v2 is published to npm.

Scarysize commented 8 years ago

Is there more to be done before I publish a v2-beta? cc @mjrussell

mjrussell commented 8 years ago

I don't think so! Can you make the tag as a beta tag so it doesn't come down as the default npm install?

Scarysize commented 8 years ago

I just have to npm publish --tag beta right?

mjrussell commented 8 years ago

yup!

uptownhr commented 8 years ago

has this happened?

Scarysize commented 8 years ago

Yes, see the README. You can install it via npm install redux-router@beta

uptownhr commented 8 years ago

thanks!

HriBB commented 8 years ago

thanks guys!