search

acdlite / redux-router

Redux bindings for React Router – keep your router state inside your Redux store
MIT License
2.3k stars 216 forks source link

Pass correct key for stringifyQuery in createAppHistory #255

Closed ianks closed 8 years ago

ianks commented 8 years ago

Previously we were using stringifyQueryString, which was ignored by createAppHistory. So now we use stringifyQuery instead.

See https://github.com/reactjs/react-router/blob/master/upgrade-guides/v2.0.0.md#custom-query-string-parsing

ianks commented 8 years ago

This will close https://github.com/acdlite/redux-router/issues/254

Scarysize commented 8 years ago

I guess we can merge this @mjrussell Could you take a quick look?

mjrussell commented 8 years ago

Yeah looks fine to me, I hadn't tested custom query strings when I upgraded to React Router 2

ianks commented 8 years ago

FWIW, I've been using this patch without issue since the commit.