acdlite / redux-router

Redux bindings for React Router – keep your router state inside your Redux store
MIT License
2.3k stars 200 forks source link

[ON HOLD] Does not work with history v3.0.0 #259

Open calvinnwq opened 8 years ago

calvinnwq commented 8 years ago

Version

v2.0.0

Steps to reproduce

npm install history@3.0.0

Expected Behavior

Should dispatch "@@reduxReactRouter/routerDidChange"

Actual Behavior

Does not dispatch "@@reduxReactRouter/routerDidChange" and router state = null

Scarysize commented 8 years ago

Thanks for the bug report. We will look into it.

mjrussell commented 8 years ago

I don't think we are going to be able to support history v3 until React Router adds support for it. react-router-redux is also waiting for React Router support first: https://github.com/reactjs/react-router-redux/issues/385

Scarysize commented 8 years ago

Okay, this is on hold for now. Thanks for the update.

digitalresistor commented 8 years ago

FYI: react-router released 3.0.0 today: https://github.com/ReactTraining/react-router/blob/master/CHANGES.md

Solwo commented 8 years ago

Ping. I'm voting up for this thread.

ghost commented 7 years ago

Ping. I'm voting up for this thread.

KamWis commented 7 years ago

Ping. I'm voting up for this thread.

calvinnwq commented 7 years ago

Any chance this will be looked at?

juampick commented 7 years ago

No updates with it? Thanks