acdlite / redux-router

Redux bindings for React Router – keep your router state inside your Redux store
MIT License
2.3k stars 216 forks source link

{ push } don`t work in actions #285

Open mikilka opened 7 years ago

mikilka commented 7 years ago

Version

2.1.2

Steps to reproduce

Add push method to actions

export const actions = {};

actions.readStaff = (id) => {
    return (dispatch) => {
        dispatch(showLoading());
        staff.read(id)
            .then((response) => {
                const data = normalize(response, [staffSchema]);
                dispatch(creators.get('readStaff')(data));
            })
            .then(() => {
                dispatch(push('/staff'));
            })
            .then(() => {
                dispatch(hideLoading());
            });
    };

Init action in the component (I also dispatch actions in container for this component)

import React, { Component, PropTypes } from 'react';
import { push } from 'redux-router';
import { connect } from 'react-redux';

@connect((state) => ({}))
export default class Menu extends Component {
    static propTypes = {
        actions:    PropTypes.object.isRequired
    };

    static defaultProps = {
        actions:    {}
    };

    constructor (props) {
        super(props);
        this._toStaff =  ::this._toStaff;
    }

    _toStaff (event) {
        event.preventDefault();
        this.props.actions.readStaff();
    }

    render () {
        return (
            <section>
                <button onClick = { this._toStaff }>to staff</button>
            </section>
        );
    }
}

Expected Behavior

Push to a new page after the response. If anybody know best solution for this, please contact me.

Actual Behavior

It dispatch push method with right route in the args, but do nothing.

image 2017-02-18 at 4 07 19 pm
lbdremy commented 7 years ago

Any updates on this ?