search

ace-lab / planning-poker

Planning Poker is a Rails application for Story Estimation with Pivotal Tracker. It uses push notifications (Faye), Bootstrap and Font-Awesome.
0 stars 1 forks source link

shifted unestimated tab to first spot #12

Closed adnanhemani closed 6 years ago

adnanhemani commented 6 years ago

Trying to solve Issue 8. This solution is not ideal at all - you'll notice that on startup, all stories will flash on the "unestimated" tab. This is due to a bad architecture of filtering - filtering for unestimated or all events happen only on DashboardController#project but not on DashboardController#index (which is run on startup). I applied a hacky fix that will filter out the irrelevant events after the page loads. This was the only way I could figure out making the necessary change - it's probably because I don't know AJAX well enough. If anyone knows how to do it better, please go ahead!

an-ju commented 6 years ago

I slightly changed the implementation to remove the flash.

Could you please add some tests to cover 1) the feature that unestimated stories are shown at first, and 2) the new helper function? Then I think the PR is good to merge.

Thanks!

an-ju commented 6 years ago

LGTM