search

ace-lab / planning-poker

Planning Poker is a Rails application for Story Estimation with Pivotal Tracker. It uses push notifications (Faye), Bootstrap and Font-Awesome.
0 stars 1 forks source link

Issue9 #13

Closed adnanhemani closed 6 years ago

adnanhemani commented 6 years ago

Should solve Issue 9. This is an extremely hacky fix, but I don't think it ruins the UX by much (if at all, it might even help). We boost the last project that the user opened (stored in session) to the front of the list of projects.

adnanhemani commented 6 years ago

This PR does somehow break tests on my local machine, but this is extremely suspect. The other PR I created tonight does not break the tests (I branched off the same commit) but there shouldn't be anything in the diff that should contribute to breaking the tests.

The tests broken also are new code for activities. @an-ju if you could take a look and let me know if there's anything that did break the tests and how, that'd be great. Thanks!

an-ju commented 6 years ago

LGTM. Please add some tests (and I guess we'll find out whether the if statement is useful or not when we have the tests).

Besides, it seems that the db files are still tracked. I'm not sure why this is the case.

You can go ahead and merge both PR after the tests are added.

an-ju commented 6 years ago

LGTM.