ace-lab / planning-poker

Planning Poker is a Rails application for Story Estimation with Pivotal Tracker. It uses push notifications (Faye), Bootstrap and Font-Awesome.
0 stars 1 forks source link

Login oauth workaround #33

Closed adnanhemani closed 5 years ago

adnanhemani commented 5 years ago

Created a new workflow for users of Google OAuth on Pivotal Tracker.

They must put in their API Token manually into the app from the login screen, and then Google OAuth will work for them in our app.

an-ju commented 5 years ago

I think the solution looks fine. Although I'd like to explain a bit more to students in the "set API key" page that we need to store their API keys in this app.

an-ju commented 5 years ago

Also, it would be good if students can remove their stored keys. I think previously API keys were not stored in this app.

adnanhemani commented 5 years ago

Previously, we would ask students to log in with their credentials and then manually go find the API keys and store them. The issue here is that since students need to log in via OAuth, we're unable to hit the Pivotal Tracker API to find their API keys. That's why we need them to manually input them into the app.

In terms of the workflow, it's nothing different than before regarding the API tokens. We stored them before and we're still storing them now - albeit now we're asking for them directly rather than finding it through the Pivotal Tracker API.

an-ju commented 5 years ago

That sounds good to me. Go ahead and merge the PR.