search

ace-wg / mqtt-tls-profile

Document for MQTT-TLS-profile
Other
0 stars 2 forks source link

Fix MQTT Connect Example Figure #83

Closed ciseng closed 2 years ago

ciseng commented 3 years ago

AD-Review: 05/08/2021

Action: Fix the issues in the two Comments.

Original Draft: +------------------------------------------------------+ |CPT=1 | Rsvd.|Remaining len.| Protocol name len. = 4 | +------------------------------------------------------+

Comment: Figure 2 appears to show that the Remaining Length field of the fixed header occupies a single octet, but IIUC it's encoded as a variable byte integer. Fixing that would also let us put the separator that appears after it on a proper byte boundary.

Original draft:

      |                      'M' 'Q' 'T' 'T'                 |
      +------------------------------------------------------+

This figure does not show the two-byte length prefix for the string.

ciseng commented 3 years ago

AD-Review: 05/08/2021

Section 6.1

Comment: [My earlier comments about the MQTT header layout apply to Figure 11 as well.]

kaduk commented 2 years ago

Fixed in the -13.