search

aceakash / string-similarity

Finds degree of similarity between two strings, based on Dice's Coefficient, which is mostly better than Levenshtein distance.
MIT License
2.53k stars 128 forks source link

IE support #38

Closed dhilt closed 4 years ago

dhilt commented 5 years ago

IE doesn't understand ES6 (const, let and arrow functions are the ES6 things that I see in the package sources) and to provide IE compatibility (curse him) we need to have our vendor bundles in ES5. And it's not easy to transpile a specific library during bundling...

The common way is to have ./dist/compare-strings.js in the npm package repo and an npm build script for ES6 -> ES5 transpilation process. If it's ok, I can provide a PR covering this situation. What do you think?

ebitauld commented 5 years ago

Also get an issue with this library and IE11 for an application developped in Angular 7: image

ludo97240 commented 4 years ago

Replace the index.js file by the one in this archive :

index.zip

Maybe a pull request can be done to fix it definitively

CMadden8 commented 4 years ago

I'm also getting this issue in IE11, it's preventing log in to the application. If the patch could be applied to the module that would really help...