search

acebrianjuan / gnss-sdr-monitor

A graphical user interface to monitor the GNSS-SDR status in real time
GNU General Public License v3.0
85 stars 38 forks source link

Duplicate #15

Closed lenhart closed 3 years ago

lenhart commented 3 years ago

Hi,

I found some duplicate code in one deserializing function which make the try statement and error handling obsolete (does not change the result though). Isn't present in the 2nd deserialization function for the pvt stream.

Upon compiling I found a few deprecated messages for qt axis and fixed them according to SO

Right now gnss-sdr-monitor isn't connecting to the gnss-sdr streams somehow.. It never worked quite as advertised, but at least displayed satellite info at some point. I don't think it is connected to the fixes I made (tested without and still not working..), but I wanted to mention it that I am pretty confident, especially about the duplicate code, but that it is basically untested.

Cheers

acebrianjuan commented 3 years ago

Hi Malte (@lenhart),

Thank you very much for fixing these. I have tested the GUI with your changes and everything works fine so I have merged them.

By the way, after reviewing the CI logs, I have noticed that there are still a bunch of similar deprecated messages affecting altitude_widget.cpp and dop_widget.cpp. Would you be so kind to fix those as well in a new pull request?

Regards, Álvaro