aceinnolab / Inkycal

Create awesome e-paper dashboards within minutes! Modularity? Check! Python3? Check? Works on Raspberry Pi Zero W? Check! Support for own modules? Check!
https://aceinnolab.github.io/Inkycal/
GNU General Public License v3.0
1.2k stars 127 forks source link

Feature request: Border around modules #236

Closed ZardoZzZz closed 11 months ago

ZardoZzZz commented 1 year ago

To make modules more defined it would be nice to have an option to add a thin border around each module. I have a iCalendar module and below this is an RSS module but it's difficult to know where one module ends and the other begins.

aceisace commented 1 year ago

How does this look? image

ZardoZzZz commented 1 year ago

Yep looks great thanks , maybe a 1 character padding between the border and the first character ?

aceisace commented 11 months ago

Implemented border feature in this commit

Closing this issue as the border feature has been implemented and the unittests are passing.

ZardoZzZz commented 11 months ago

Hi Ace,

I see this is closed now, what is a border feature ? And is it working now , what do I need to do on my RP to get the weather to my local time zone?

Thanks for all the help have a great weekend.

aceisace commented 11 months ago

Hi there, the border feature basically draws a 1px border around each module when the settings in the settings.json file is set to show the border. The main aim is a better fine-tuning of each module's height so that the already limited space on the display can be utilised more efficiently.

You can try out the feature with the following steps:

sudo apt-get install wkhtmltopdf -y
cd ~/Inkycal
git pull
source venv/bin/activate
pip install -r requirements.txt
# To test if Inkycal is still running fine:
python inky_run.py

If the test works fine, you can reboot the Raspberry Pi (sudo reboot) so the changes are applied after the reboot.

Concerning the timezone feature, this is currently in progress (see the other issue) and will be finished soon. One of the main reasons this got delayed quite a bit was due to the pyowm library, which is not being maintained anymore since years and would eventually lead to larger problems in the long-term. As a result, a custom wrapper had be implemented to achieve the same, but without the pyowm library. The tests so far are looking good, so more weather-related features can be implemented, including fixing the timezone.

ZardoZzZz commented 11 months ago

Thanks Ace 🙂

aceisace commented 11 months ago

You're welcome!