acejump / AceJump

🅰️ single character search, select, and jump
https://plugins.jetbrains.com/plugin/7086-acejump
GNU General Public License v3.0
1.23k stars 91 forks source link

Do not bundle kotlin stdlib #450

Closed chylex closed 1 year ago

chylex commented 1 year ago

Fixes #449

Wanted to run this by you first.

  1. Changed the Kotlin plugin version to match the one bundled in IDEA 2023.2 (see comment link for a table)
  2. This version of the Kotlin plugin has broken incremental compilation so I disabled that too
  3. According to https://kotlinlang.org/docs/gradle-configure-project.html, the toolchain notation can be shortened and it should set jvmTarget automatically

I ran into some issues building the plugin in master - if I run buildPlugin then it crashes on some L&F error during the test task... but if I run test on its own, and buildPlugin without the dependency on test, everything succeeds. Not sure if it's just something on my machine, but regardless it's not caused by these changes.

breandan commented 1 year ago

Thanks @chylex